-
Notifications
You must be signed in to change notification settings - Fork 61
ModelicaSystemCMD - use OMCPath #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
syntron
wants to merge
67
commits into
OpenModelica:master
Choose a base branch
from
syntron:ModelicaSystemCmd_use_OMCPath
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
ModelicaSystemCMD - use OMCPath #324
syntron
wants to merge
67
commits into
OpenModelica:master
from
syntron:ModelicaSystemCmd_use_OMCPath
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents * fix some type hint issues in setInput() * prepare for definition via dictionary replacing 'a=b' and '[a=b, c=d]' style
* rename from setMethodHelper() * use _prepare_inputdata() * cleanup code to align with new input as dict[str, str] * setInput() is a special case
* replace eval() with ast.literal_eval() as a saver version * use _prepare_input_data() * simplify code
This method is used to set input values. It can be called with a sequence of input name and assigning corresponding values as arguments as show in the example below. Compared to other set*() methods this is a special case as value could be a list of tuples - these are converted to a string in _prepare_input_data() and restored here via ast.literal_eval().
* not working: 3.10 * working: 3.12
… this code (int or str)
* this is scripting output and, thus, it cannot be parsed
* the result is the ready-to-use definition of the command needed to run the model executable
* one windows this defines the local working directory to be used * for docker or WSL this should NOT be set as this directory does NOT exists locally
@Sonyoyo feel free to also test this PR - it should allow you to use ModelicaSystem in combination with OMC in WSL Test case to check: Please keep in mind that Python >= 3.12 is needed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use OMCPath in ModelicaSystemCMD - this allows to run ModelicaSystem simulations using docker or WSL
Please check
tests.test_ModelicaSystem.test_getSolutions_docker
for an exampleBased on PR #322